On Jun 24, 2009, at 6:56 AM, Peter Dennis - Sustaining Engineer wrote:
Shawn Walker wrote:
On Jun 23, 2009, at 11:41 AM, Peter Dennis - Sustaining Engineer
wrote:
Webrev:
http://cr.opensolaris.org/~petede/gate/
bug:
http://defect.opensolaris.org/bz/show_bug.cgi?id=8536
Comment:
As per the bug, PyErr_NoMemory() returns a PyObject*
(though in reality this is null) and so cast to void.
This looks good, although the only thing I would note is that we do
have a call in modules/elfextract.c on line 510 for liblist_foreach
that doesn't check the return value.
I've modified the code to capture that return and take the appropriate
action (goto bad).
Webrev updated:
http://cr.opensolaris.org/~petede/gate/
Seems right to me.
Cheers,
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
