On Thu, Jul 09, 2009 at 03:12:52PM -0500, Shawn Walker wrote: > The issue is primarily of storage by name where some characters > won't be allowed in file names or create other issues. I suppose > that could be handled just by enforcing URL-encoded filenames when > delivering the licenses into an image.
Yeah. > It seems that you feel the guidelines are the best way to handle > this, so I'll simply remove this part about restricting the name. Please. > >> * The ImagePlan object will have a new method named 'set_license' > >> which will allow callers to mark the explicit acceptance of a > >> package's license by a user: > >> > >> set_license_status(fmri, license_keyword, status) > > > >Typo: set_license()? > > No, intentional. My thought was that set_license_status was clearer > than set_license. Then you'll want to change the first sentence of the bullet to use set_license_status() instead of set_license(). > In particular, I didn't want individual subcommands to be processing > and parsing this information; I felt that since it controlled the > overall behaviour of the client that it was preferable to specify it > a global level, and was easier to document, easier to explain, and > would ensure consistency. That's a matter of code organization more than anything else, really. I don't really feel strongly about this, but if we're going to go in this direction, then --no-refresh should probably be global as well, and perhaps one or two others. We'll probably want to do a pass over the CLI at some point before LTS to make sure it's consistent at the time, and with whatever thoughts we might have on its future evolution. > However, I see now that if the user does this: > > pkg set-policy policy-1 'value 1' 'policy 2' value-2 > > Then that will be seen as only four arguments and it won't "split" > at the spaces (which is what I was thought it would so for some > reason). If they leave off the quotes of course, then things aren't > so rosy, so I'll just need to mention that in the man page. I'm not > certain if that's a getopt behaviour or a shell behaviour. Shell. Each argument is put into a separate element in argv, and shells give you a way to ensure that a specific set of characters is a single argument, rather than splitting on space like they normally do for you. Danek _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
