This looks fine to me.

Just one comment, though, which may be mostly orthogonal to this project,
but has some tie-in with the action's attributes.

I've been mulling over how to fix the license action to install in a
central location, rather than in the package-version-specific directory it
currently does.  In particular, if two license actions in the same package
deliver payloads with different hashes, but call it the same thing in the
"license" tag, then there will be problems.

I think the way around this will be to treat the "license" tag as a more
expressive license description.  It needn't be long, and something short,
like "GPLv2" would be perfectly suitable, if it's the canonical text of
version 2 of the GPL.  But if it's not, then this would be the appropriate
place to put a short explanatory note, like "v2 only" or "with Linux kernel
exception" or whatever.

In order to be able to classify licenses -- putting all the GPL licensed
packages together -- I think a new attribute is best.  Call it "class" or
"family" or something, but this would be much more limited in what its
values should be.

Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to