On Wed, Jul 22, 2009 at 04:56:33PM -0500, Shawn Walker wrote:
> Greetings,
>
> The following webrev contains fixes for the following issues:
>
>   8863 error message unclear when trying to disable preferred publisher
>
> webrev:
> http://cr.opensolaris.org/~swalker/pkg-8863/

Just a couple of questions:

api.py:

  - line 53: Is it necessary to rev the version on the API here?  If exception
  handlers are configured to catch the base class, then this change has no
  negative impact.

api_errors.py:

  - line 795:  This error message is better, but still a little vague.
    Off the top of my head, here are a couple of suggestions:

  "The preferred publisher may not be disabled."

  or

  "An image must always have one preferred publisher.  You must change the
  preferred publisher before disabling this publisher."

-j
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to