[email protected] wrote:
On Wed, Jul 22, 2009 at 04:56:33PM -0500, Shawn Walker wrote:
Greetings,
The following webrev contains fixes for the following issues:
8863 error message unclear when trying to disable preferred publisher
webrev:
http://cr.opensolaris.org/~swalker/pkg-8863/
Just a couple of questions:
api.py:
- line 53: Is it necessary to rev the version on the API here? If exception
handlers are configured to catch the base class, then this change has no
negative impact.
The way the api versioning works (as I understand it) is that visible
changes to the api cause an api rev, and depending on whether that
change is compatible, a change to the compatible_versions list as you'll
see on line 89 of pkg.client.api.
In this case, it's a visible change to the api, but it is compatible
with previous versions, hence the rev.
api_errors.py:
- line 795: This error message is better, but still a little vague.
Off the top of my head, here are a couple of suggestions:
"The preferred publisher may not be disabled."
or
"An image must always have one preferred publisher. You must change the
preferred publisher before disabling this publisher."
I have opted for:
"The preferred publisher may not be disabled. Another publisher must be
set as the preferred publisher before this publisher can be disabled.
Thanks for the review,
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
