I have respun the webrev, http://cr.opensolaris.org/~padraig/ips-10192-v2/,
to take account of these comments.
Padraig
On 07/23/09 16:34, Danek Duvall wrote:
On Wed, Jul 22, 2009 at 04:03:44PM +0100, Padraig O'Briain wrote:
http://cr.opensolaris.org/~padraig/ips-10192-v1/
You need to undo the redirection to /dev/null that you'd introduced in the
previous attempt to fix this.
It might make sense, in misc.py, to do
from pkg.gui.misc_non_gui import CLIENT_API_VERSION, get_cache_dir, \
read_cache_file, dump_cache_file, get_api_object as ng_gao
and then you don't have to provide wrappers for those functions. You could
also, in checkforupdates.py, "import pkg.gui.misc_non_gui as gui_misc" and
have to change less code.
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
