Brock, On Mon, Aug 17, 2009 at 08:31:35PM -0700, Brock Pytlik wrote: > http://cr.opensolaris.org/~bpytlik/ips-10515-v1/ > > 10515 search should support -o for output like pkg contents > 10608 search should support -H option for output
Meta-comments from me this time. I'm concerned about our use of valid_special_attrs, and related lists. In general, it would be nice if we could filter on package attributes as actions add them, without having to write code to do so. Since the search output and contents output are trying to behave similarly, they should probably share code. Perhaps I missed it, but I didn't see any changes to the contents routine. The search() method in client.py is getting large and heavily indented. If possible, please extract some of that code into other methods. Thanks, -j _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
