[email protected] wrote:
Shawn,
Thanks for the review.
On Tue, Sep 29, 2009 at 03:47:42PM -0500, Shawn Walker wrote:
* Should the "w" be "wb" where it is used?
The previous code used "w" which is why I didn't bother to change it.
The manifests are text.
Yes, but the "b" ensures interoperability with Windows, et al. I just
thought this would be a good time to fix that :)
* It seems that __file_path could be expressed in terms of __file_dir
plus an os.path.join now.
Sorry, a little confused here. Do you mean:
return os.path.join(self.__file_dir(), name)
If so, I'm fine with making that change.
Yes.
Cheers,
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
