On Tue, Sep 29, 2009 at 04:50:54PM -0500, Shawn Walker wrote: > [email protected] wrote: >> Shawn, >> >> Thanks for the review. >> >> On Tue, Sep 29, 2009 at 03:47:42PM -0500, Shawn Walker wrote: >>> * Should the "w" be "wb" where it is used? >> >> The previous code used "w" which is why I didn't bother to change it. >> The manifests are text. > > Yes, but the "b" ensures interoperability with Windows, et al. I just > thought this would be a good time to fix that :)
Yes, but presumably it has been working just fine on Windows all along, otherwise we would have fixed this sooner. To make matters more confusing, tempfile.mkstemp() opens the underlying files in binary mode by default, so the underlying fd has whatever binary mode flags it needs set. The call to os.fdopen just checks that the mode starts with 'a', 'r', or 'w' and then passes the flags to fdopen(3C). Solaris ignores the b flag, but accepts it for ISO conformance. I'll add the 'b' on the end, but it's not at all clear that it makes any difference here. >>> * It seems that __file_path could be expressed in terms of __file_dir >>> plus an os.path.join now. >> >> Sorry, a little confused here. Do you mean: >> >> return os.path.join(self.__file_dir(), name) >> >> If so, I'm fine with making that change. > > Yes. Fixed. -j _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
