Brock Pytlik wrote:
> http://cr.opensolaris.org/~bpytlik/ips-7960-v3/
I'm assuming that support for different hash, hash encoding, and
compression algorithms are as-needed future work?
file_manager.py:
- line 94, et al: "parameter"
- line 99: raise a ValueError, maybe?
- line 114: pull next line up? Or put 116 on 115.
- line 180: if the file is already in the datastore under a different
layout, shouldn't it be moved?
- line 189, 224: can be on previous line.
- line 194: how is this different from os.removedirs?
layout.py:
- line 59: "detrimental"
- line 62: "convenient"
- line 64: "support"
- line 68: "tradeoffs"
- line 80, 94, 104: "hash" doesn't match parameter name
- line 95, 105: why the conversion to string? Aren't you being passed in
a string in the first place?
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
