Danek Duvall wrote:
Brock Pytlik wrote:
http://cr.opensolaris.org/~bpytlik/ips-7960-v3/
I'm assuming that support for different hash, hash encoding, and
compression algorithms are as-needed future work?
Different hash algorithems are future work. From the people I spoke
with, there seemed agreement that supporting hash encodings other than
hex wasn't going to be needed, at least not anytime soon.
Compression algorithms hasn't come up at all, so I'm not sure what
you're referring to there, but my guess is yes, future work.
file_manager.py:
- line 99: raise a ValueError, maybe?
Sure
- line 180: if the file is already in the datastore under a different
layout, shouldn't it be moved?
Good point, I'll add that in.
- line 194: how is this different from os.removedirs?
It's not, I'll switch to that.
layout.py:
- line 95, 105: why the conversion to string? Aren't you being passed in
a string in the first place?
Probably a relic from when hashval's were more than strings. I'll change
that too.
Brock
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
