On Thu 22 Oct 2009 at 04:17PM, John Sonnenschein wrote:
> http://cr.opensolaris.org/~error404/3107/
>
Can you explain this code? Will it be readable to others?
Why no comment?
Why import sys right here rather than at the top of the file?
Why print to stderr?
175 + canwrite = False
176 + import sys
177 + print >> sys.stderr, self.attrs["mode"]
178 + for x in ['2','3','6','7']:
179 + if x in self.attrs["mode"]:
180 + canwrite = True
This seems to me to be too clever by at least half. Also, indentation does not
match the gate's style.
I thought the idea of this bug was that, if the E file still had
the factory original perms/owner/group/etc., then we would update it.
For those attrs where the sysadmin had made changes, we would leave those
alone...
-dp
--
Daniel Price, Solaris Kernel Engineering http://blogs.sun.com/dp
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
