Brock Pytlik wrote:

> http://cr.opensolaris.org/~bpytlik/ips-12475-v1/

You're not actually using getopt.  I'd also mention something about file
layout in the error message, 'cause otherwise this is all pretty cryptic.
In fact, I'd have a comment in the file talking about what it actually
does.

In testutils, don't forget that no spaces should surround equals signs in
argument lists.

Looks fine otherwise.

Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to