Shawn Walker wrote:
Brock Pytlik wrote:
http://cr.opensolaris.org/~bpytlik/ips-12475-v2/
Updated webrev which addresses the issues raised including adding more comments. I've posted it again in case the error messages or documentation still needs tweaking.

So, I think I'd rather see a general 'pkg.depotadm' or 'depotadm' or 'repoadm' utility with the functionality here being an 'upgrade' subcommand. In particular, I believe that would help make it clearer that this program is for a package repository only.

Except it's not for a package repository only. It can be used happily on a client image though the use case is somewhat less compelling.

I'd be happy to see this pulled into a depotadm or whatever when that comes along, if it's still needed at that point. For now, I think it belongs in a one-off script.
Stephen and I discussed having this sort of utility a few months ago because it was becoming increasingly apparent that there were a number of administrative functions for repositories that having a cli program to perform would be useful.

Because of the catalog v1 work, I hadn't had time yet to get around to writing something more formal up, but if you could simply rename this program and move the current functionality to a subcommand ("migrate"), we could expand on its functionality from there at a later date.
I don't have strong feelings about this other than that I'd like to get it put back reasonably soon so that it's available for RE and Dan when they decide to make the shift. If they don't need it put back to the gate at all, I'm fine with it just sitting in a workspace in my gate.

That shouldn't require much change from what you have already here, and would help avoid extra effort later (such as removing this new program and moving its functionality into utility mentioned above).

Cheers,

Brock
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to