On Tue, Jan 19, 2010 at 10:14:54AM -0800, Bart Smaalders wrote: > On 01/15/10 17:31, Mark J. Nelson wrote: > >This is for the work discussed here: > > > >http://mail.opensolaris.org/pipermail/pkg-discuss/2010-January/019874.html > > > >The webrev: http://cr.opensolaris.org/~mjnelson/webrev.pkgmog.ops/ > > > >After I send this note, I'll send the on_ips code review request for > >our use of the new functionality, and will cc pkg-discuss. > > > >--Mark > >_______________________________________________ > >pkg-discuss mailing list > >[email protected] > >http://mail.opensolaris.org/mailman/listinfo/pkg-discuss > > A couple of nits: > > This code creates the printfile empty even if there's no > print action. Is this desirable/intentional?
Yes. If they default to stdout, then it doesn't really matter. If they passed a "-P printfile" option to the command, then I think it's appropriate to get an empty output file. > Original proposal suggested that print and output would be > intermixed... this is not the case in this code. Right, I think I mentioned that in the bug report, when I realized that it wasn't happening that way. > If the above is what you want, this is fine. Yes. Thank you. --Mark _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
