Addendum: I felt that I should extend the tests for these. http://cr.opensolaris.org/~mjnelson/webrev.pkgmog.tests/
(the script and manpage changes have already been reviewed, the new tests and baseline have not.) --Mark On Tue, Jan 19, 2010 at 10:14:54AM -0800, Bart Smaalders wrote: > On 01/15/10 17:31, Mark J. Nelson wrote: > >This is for the work discussed here: > > > >http://mail.opensolaris.org/pipermail/pkg-discuss/2010-January/019874.html > > > >The webrev: http://cr.opensolaris.org/~mjnelson/webrev.pkgmog.ops/ > > > >After I send this note, I'll send the on_ips code review request for > >our use of the new functionality, and will cc pkg-discuss. > > > >--Mark > >_______________________________________________ > >pkg-discuss mailing list > >[email protected] > >http://mail.opensolaris.org/mailman/listinfo/pkg-discuss > > A couple of nits: > > This code creates the printfile empty even if there's no > print action. Is this desirable/intentional? > > Original proposal suggested that print and output would be > intermixed... this is not the case in this code. > > If the above is what you want, this is fine. > > - Bart > > > > -- > Bart Smaalders Solaris Kernel Performance > [email protected] http://blogs.sun.com/barts > "You will contribute more with mercurial than with thunderbird." _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
