On 02/23/10 06:22 AM, Tim Foster wrote:
Hi all,
I've got a wad of usability/aesthetic fixes I'm hoping
to get a code review of please?
1797 packages without filesystem content appear empty
14625 incorrect error message for 'contents -a foo'
13814 extraneous blank lines now printed after plan creation
13813 progress cursor for "pkg verify" doesn't cleanup after long package names
http://cr.opensolaris.org/~timf/1797-contents
src/client.py:
line 2045: If the user specified '-m' do we really want to re-sort
the contents since it's supposed to be the "raw" display, or do we care?
lines 2053-2057:
simplify to:
for line in buf:
msg(line)
return len(buf) > 0
lines 2296-2314: You may want to ask BJ about the string addition;
we're pretty late in the release cycle.
line 2297:
s/with the fields specified with the -o option./with the fields
specified using the -o option./
(Just trying to get rid of the multiple uses of 'with' in the
same sentence.)
lines 2310-2311: The formatting seems odd here.
Cheers,
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
