Hi Shawn, On Tue, 2010-02-23 at 14:57 -0600, Shawn Walker wrote: > > I've got a wad of usability/aesthetic fixes I'm hoping > > to get a code review of please? > > > > http://cr.opensolaris.org/~timf/1797-contents
Thanks for taking a look. > src/client.py: > line 2045: If the user specified '-m' do we really want to re-sort > the contents since it's supposed to be the "raw" display, or do we care? Good point. I did a quick check, sorting vs. not sorting when doing a 'pkg contents -m' on an image installed with redistributable. This returned 500589 actions. It differed by 4%, or about 3 seconds. I didn't think that was a huge difference given the large number of actions. When getting the raw contents for SUNWcs, the difference was barely measurable. > lines 2053-2057: > simplify to: > for line in buf: > msg(line) > return len(buf) > 0 Thanks. > lines 2296-2314: You may want to ask BJ about the string addition; > we're pretty late in the release cycle. Ok. > line 2297: > s/with the fields specified with the -o option./with the fields > specified using the -o option./ > (Just trying to get rid of the multiple uses of 'with' in the > same sentence.) Sounds good. > lines 2310-2311: The formatting seems odd here. That was intentional - I was trying to highlight the differences between the plural and singular forms, thinking it was easier to read this way - I can wrap all lines to 90 chars if you'd prefer? I've updated the webrev at http://cr.opensolaris.org/~timf/1797-contents cheers, tim _______________________________________________ pkg-discuss mailing list pkg-discuss@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
