Thanks Padraig - tweaked it a bit to put in a finally handler that
covers your comments.
http://cr.opensolaris.org/~jmr/pm_16040_optimize_inc_search_25May_340pm
JR
On 05/25/10 02:59 PM, Padraig O Briain wrote:
Is line 1543 necessary?
1543 + self.search_results_id = 0
Should you have lines like the following when exception occurs?
if self.search_results_id != 0:
gobject.source_remove(self.search_results_id)
self.search_results_id = 0
Padraig
On 05/25/10 02:57 PM, John Rice wrote:
Here's a respin after a review with Padraig, to change the logic to
ensure that we always update the list after the delay. The previous
worked fine, but if the way the results came back changed we might
have had no results returned incrementally.
Bug 16040 Optimize search return results
http://cr.opensolaris.org/~jmr/pm_16040_optimize_inc_search_25May_250pm
JR
On 05/24/10 03:59 PM, John Rice wrote:
Hi Joanie - thanks for catching this. Here's a webrev that should
significantly cut down on the amount of work PM is doing during a
search.
We currently update the main list each time an incremental search
result is returned. As search gives back one for each result, this
can prove needlessly expensive as you pointed out :)
The webrev, introduces an incremental search result update delay of
0.6 sec to manage this more sensibly. It has the effect of
collapsing results together that are returned within this delay and
its quite effective as results tend to clump together time wise. So
for instance in searching for "python" against opensolaris.org and
contrib which returns 40 results, the main list is now being updated
3 times during the search, not 40 as it was before.
Bug 16040 Optimize search return results
http://cr.opensolaris.org/~jmr/pm_16040_optimize_inc_search_24May_340pm
If you could give it a spin that would be great.
Thanks.
JR
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
