[email protected] wrote:
> http://cr.opensolaris.org/~johansen/webrev-16653/
Cool beans. I was wondering if something like this would be worth doing,
and it looks nice. A couple of small comments ... feel free to do with
them what you want:
- If the lock objects are contextmanagers, you can do "with lock: ..."
which might be nicer than the acquire/try/finally/release cycle, but
since that only shows up three times now, it's less intrusive.
- Why didn't get_versions() or captive_portal_test() get converted?
- line 195 you might be able to write as instance = fargs.pop(0).
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
