On 08/23/10 10:21 PM, [email protected] wrote:
Folks, Over time the pkg(5) source code has sprouted a number of different, independent file locking routines. This leads to a maintenance hassle for the code, as any change to the locking code generates updates in various places, if any bugs are found. This change makes the code common, but customizable, so differnet modules can implement different behaviors. I fixed a couple of additional locking bugs that were discovered along the way.http://cr.opensolaris.org/~johansen/webrev-14615/
src/modules/client/image.py: line 393: debug code? src/modules/lockfile.py: lines 68-72: why are these protected instead of private? line 77: s/ = / = / line 87: why not drop the else: and simply return? line 175: nit: insert newline here line 177: docstring? src/modules/misc.py: line 815: nit: insert newline here Otherwise, seems right to me. -Shawn _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
