[email protected] wrote:

>       http://cr.opensolaris.org/~johansen/webrev-10390/

pull.py:

  - line 447: You might add a comment explaining why you have an alternate
    transport and config objects.  Should they be "src_xport" and
    "dst_export" or something?

  - line 549: I'd change the formatting a tiny bit:

        Skipping %s: already present at destination.

    or

        Already present at destination: %s.  Skipping.

  - line 582: typo?

t_pkgrecv.py:

  - line 477: shouldn't we be using pkgrepo to create repos now?  Actually,
    aren't there facilities in pkg5unittest for this, or are those not
    appropriate here?

Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to