Hi Danek, Thanks for reviewing this. On Fri, Sep 03, 2010 at 02:13:19PM -0700, Danek Duvall wrote: > [email protected] wrote: > > > http://cr.opensolaris.org/~johansen/webrev-10390/ > > pull.py: > > - line 447: You might add a comment explaining why you have an alternate > transport and config objects. Should they be "src_xport" and > "dst_export" or something?
I added a comment and changed alt_xport to dest_xport. > - line 549: I'd change the formatting a tiny bit: > > Skipping %s: already present at destination. I changed it to the above, thanks. > - line 582: typo? Yes, removed. > t_pkgrecv.py: > > - line 477: shouldn't we be using pkgrepo to create repos now? Actually, > aren't there facilities in pkg5unittest for this, or are those not > appropriate here? Not sure. I was just imitating the other examples in previous parts of the pkgrecv unit test. I can change this to pkgrepo instead of pkgsend, if this is in the pkg5unittest code already. Thanks, -j _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
