Hey Shawn,
On Fri, Sep 10, 2010 at 06:48:19PM -0700, Shawn Walker wrote:
> Greetings,
>
> The following webrev contains changes for the following items:
>
> 2775 pkg should provide a way to downgrade (reinstall) packages
> 15462 pkg install subcommand needs to indicate it can be used for
> update too
>
> webrev:
> http://cr.opensolaris.org/~swalker/pkg-2775/
Just minor stuff here.
client.py:
- line 1497: You have a XXX comment here.
pkg.1.txt:
- lines 227 - 229: I might split this into two sentences. One
possible revision might be:
Install or update the packages specified in pkg_fmri_pattern to the
newest version. This operation is subject to constraints imposed by
other packages that are already installed in the image.
- lines 271 - 275: I find that this sentence implies that reinstall
will always move a package forward. I know that's not the case, but
the connotation of newest implies that it might be so.
How about the following?
Replace an installed package that matches pkg_fmri_pattern with an
alternate version. The version is specified by the
pkg_fmri_pattern. This operation is useful when a package needs to
be downgraded in place. Reinstalls across package rename or
obsolete boundaries are not currently supported.
- line 321: How about?
Removes installed packages that match pkg_fmri_pattern
actions/file.py:
- line 154: Does this code need any special handling for a situation
where it doesn't recognize the preserve type? I'm assuming we do
nothing for backward compatibility, but I didn't know if this should
log a warning, or disable any additional behavior if the type is
unrecognized.
image.py:
- Thanks for changing the make_XXX_plan code to be more common here.
-j
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
