On Wed, Sep 22, 2010 at 03:39:45PM -0700, Shawn Walker wrote:
> On 09/10/10 06:48 PM, Shawn Walker wrote:
> >Greetings,
> >
> >The following webrev contains changes for the following items:
> >
> >2775 pkg should provide a way to downgrade (reinstall) packages
> >15462 pkg install subcommand needs to indicate it can be used for update
> >too
> >
> >webrev:
> >http://cr.opensolaris.org/~swalker/pkg-2775/
>
> Updated webrev:
> http://cr.opensolaris.org/~swalker/pkg-2775-v1-v2/
Looks good. I have one really minor nit.
pkg_solver.py:
- line 495: Would you move this comment to after the timeit() call? I
was initially confused by this, because I didn't see the trim until
a few lines later, and was puzzled about why timeit() would be doing
any trimming.
-j
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
