Brock Pytlik wrote: > This is a misleading webrev, while the number of changes is large, > all the changes to certificates are a result of the changes to > openssl.cnf and generate_certs.py. All the files after openssl.cnf > are automatically generated.
Why not just run generate_certs as part of the testsuite? > http://cr.opensolaris.org/~bpytlik/ips-16856-v1/ I think these changes constitute an incompatible API update. publisher.py: - line 2098: "provide" -> "provided"? t_pkgsign.py: - test_inappropriate_use_of_code_signing_cert(): I can't say I'm following this all that well, but are you using the wrong type of cert to sign a package? If so, then why aren't we detecting a problem when we sign the package, rather than waiting until we install it? Danek _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
