On 01/28/11 02:52 PM, Brock Pytlik wrote:
On 01/28/11 02:10 PM, Danek Duvall wrote:
Brock Pytlik wrote:
I think these changes constitute an incompatible API update.
Could you explain why? As far as I'm aware, there's no impact across
the api boundary.
Well, you're adding new exceptions, so that's a change, though
compatible.
But you're also making incompatible changes in client/publisher.py, which
has the following comment at the top:
# NOTE: Any changes to this file are considered a change in client api
# interfaces and must be fully documented in doc/client_api_versions.txt
# if they are visible changes to the public interfaces provided.
Shawn put that comment in when he added the file, so I have no reason to
believe otherwise.
Since check_extensions (and check_critical) are/were public functions,
you're right, this is an api change. I'll fix that.
Please note that if the API is revisioned incompatibly (such as in this
case, since the number of positional arguments to a few functions was
changed), putback will require coordination with the install team.
Specifically, they need to be made aware of when the change will happen
and for which build. The install team's gate closes before ours does
(ours is the last), so advance notice is needed.
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
