On 03/21/11 01:04 PM, Tim Foster wrote:
Hi there,

I've got a webrev at
http://cr.opensolaris.org/~timf/pkglint-file-move-webrev/

that I'd appreciate a code review of.

Rather worryingly, it seems that pkglint couldn't deal with files that
move between packages, when using a reference repository containing
original versions of the packages involved in the move.

Comments would be great - thanks,

        cheers,
                        tim

_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
Hi Tim, this looks like the right fix for this bug, but I was wondering something as I was looking at this.

Why is there a ref_dict that doesn't include the packages I'm delivering? If I'm delivering a new version of a package, will I ever care about the older versions in the ref_dict? If so, could you help me understand when? If not, then I wonder whether we could come across similar bugs in other situations where delivered packages are lint clean, but reference ones aren't.

For example, if you had reference packages a@1 (which delivered /foo as a directory) and b@1 (which delivered /foo as a symlink), and you were delivering a@2 and b@2, both of which agree that /foo is a directory, wouldn't you get a similar problem from the duplicate_path_types check?

Thanks,
Brock
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to