Hi Brock,
On Mon, 2011-04-11 at 13:36 -0700, Brock Pytlik wrote:
> On 04/10/11 06:57 PM, Tim Foster wrote:
> > http://cr.opensolaris.org/~timf/pkglint-file-move-webrev-1
Thanks for taking a look,
> pkglint_action:
> line 495, 496: aren't these lines over-indented?
Oops, yes.
> Complete nit: line 135: I find the phrase "with any for which" makes my
> head want to explode... and I don't even know why.
I think it's correct, but don't want head explosions. We had:
# construct a set of FMRIs being presented for linting, and
# avoid seeding the reference dictionary with any for which
# we're delivering new packages.
I'll replace with:
# construct a set of FMRIs being presented for linting, and
# avoid seeding the reference dictionary with any packages
# that have new versions available in the lint repository, or
# lint manifests from the command line.
> Forgot one other thing, the two for loops could be combined into one if
> you used itertools.chain to put the two things your looping over into
> one big iterable. I don't know if that's better/easier to read or not.
> Your call :)
Fair point (I don't often use itertools, and probably should) I had a
go, and it didn't seem to make it much better. I'll leave it the way it
is I think.
cheers,
tim
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
