Hi Shawn,

On Mon, 2011-03-28 at 13:02 -0700, Shawn Walker wrote:
> webrev:
>    http://cr.opensolaris.org/~swalker/pkg-legacy/

This looks good to me.

I think it'd be worthwhile documenting the preserve=legacy attribute in
src/man/pkg.5.txt.

One other question: how does 'pkg revert' work with a preserve=legacy
action when run after an initial install of a package with such an
action?

Should it revert to the "this isn't the file you're looking for" content
that initially wasn't stored on disk, should it recover the file that
had been moved to the salvage area, or should it behave the same as 'pkg
fix' and do nothing?

[ I saw that you've got a test for 'revert' when upgrading a
preserve=legacy action, I just wasn't sure what would happen after an
initial install ]

        cheers,
                        tim




_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to