On 04/18/11 05:42 PM, Edward Pilatowicz wrote:
On Mon, Apr 18, 2011 at 03:13:05PM -0700, Brock Pytlik wrote:
On 04/15/11 05:41 PM, Edward Pilatowicz wrote:
On Wed, Mar 30, 2011 at 09:36:05PM -0700, Brock Pytlik wrote:
Here's the system repository work that Tim and I have been working
on for quite a while now.
http://cr.opensolaris.org/~bpytlik/ips-sysrepo-v1/
more comments.
ed
----------
src/modules/client/imageconfig.py
- it seems you've made "preferred-authority" irrelevant, so why not just
remove it? (if it's being kept for backward compatability then a
comment to that effect somewhere would be good.) also, it seems that
all the code in write() that sets ppub can be removed since you removed
the only consumer.
You'd have to be more specific. It's kept in version 2 of image
configs for backwards compatibility.
so it seems to be present in both versions 2 and 3. i'm not sure how
versioning here works, perhaps shawn can explain?
it seems to me you need bump the version number and remove the
parameter, or there needs to be some comment which tells the next person
who does introduce config v4 that they should remove this parameter in
that version. (or perhaps we keep all dead parameters around in all
future versions? in which case a comment explaining this would be
nice.)
I only bump versions if the format of values changes or if we remove
properties.
As long as we're still reading them in for image format migrations,
there's not much reason to bump the version.
I leave Brock to decide what to do here.
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
