On 04/19/11 06:41 PM, Edward Pilatowicz wrote:
On Wed, Mar 30, 2011 at 09:36:05PM -0700, Brock Pytlik wrote:
Here's the system repository work that Tim and I have been working
on for quite a while now.
http://cr.opensolaris.org/~bpytlik/ips-sysrepo-v1/
my last comments are below.
sorry for dribbling them out for so long.
ed
----------
src/modules/client/imageconfig.py
- nit: in __merge_publishers() instead of doing:
res = {}
for p in sys_cfg.publishers:
res[p] = sys_cfg.publishers[p]
how about:
res = sys_cfg.publishers.copy()
I'll see if that works. In general, I prefer to not use copy b/c it
means you need to know exactly what type you're dealing w/ (and how it
implements copy vs deepcopy), something that's not as simple as it
sounds in python.
Brock
----------
src/sysrepo.py
I'll let tim speak to these.
- nit: s/file the the/to the/ here:
That is, it copies /var/pkg/pkg5.image file the the htdocs
- let's remove the default port of 1008 and just require that users
specify one. (really, i think the only place that we should reference
port 1008 should be in the sysrepo manifest.)
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
