Hi Krister,
On Tue, 2011-05-10 at 16:10 -0700, [email protected] wrote:
> Folks,
> Here's a webrev for some zoneproxy fixes that didn't make the cutoff for
> b165.
> http://cr.opensolaris.org/~johansen/webrev-18277/
src/svc/svc-pkg-sysrepo, line 142 - nit: could this use "/usr/bin/pkill"
instead of "pkill"
src/zoneproxy/zoneproxyd/zoneproxyd.c
Removing the option to pass configuration on the command line will make
testing a little more complex for this binary. Would it be worth
leaving those in, as an aid to test case development.
Also I wonder whether we'd ever want (or could support?) multiple
instances of the zone proxyd, with separate communication channels for
different zones, in which case, hardcoding a single system-repository
service instance seems wrong unless there are manual overrides available
from the CLI.
Other than that, I'm not enough of a c-programmer to be able to properly
review the other changes, but I did look at them, and they seem ok.
cheers,
tim
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
