On Tue, May 10, 2011 at 05:40:42PM -0700, Edward Pilatowicz wrote: > On Tue, May 10, 2011 at 04:10:26PM -0700, [email protected] wrote: > > Folks, > > Here's a webrev for some zoneproxy fixes that didn't make the cutoff for > > b165. > > > > http://cr.opensolaris.org/~johansen/webrev-18277/ > > > > nice.
Thanks for the speedy review. > ---------- > src/zoneproxy/zoneproxyd/zoneproxyd.c > > - DEFAULT_HOST and DEFAULT_PORT don't seem to be used anywhere. These are used on lines 1718 and 1722, as defaults if the SMF configuration cannot be read. > - 718-719, check for NULL from strdup()? Yes, thanks. > - did you verify what happens to existing socket connections to the > sysrepo when that process exist? (do the connections immediately get > reset and does that propegate back to the zoneproxy-client? if so a > comment to that effect in s_handler() might be nice.) I haven't done this yet, since I'm not actually sure how to generate a sysrepo configuration change that changes the sysrepo host/port. I was going to talk to Brock about that this afternoon. At a high level, this probably doesn't matter much, since the client's transport will re-try any failed requests, and will timeout requests that don't finish within a certain period of time. Thanks again, -K _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
