Shawn Walker wrote:
> http://cr.opensolaris.org/~swalker/pkg-composite-2/
catalog.py:
- line 3411: this disallows ver == 0, if I'm reading it correctly.
image.py:
- line 2577-2580: list comprehension?
publisher.py:
- line 1238,1239: First "list", then "set", plus the name of the method?
- line 1313: urlencoding instead of hashing the uri would make for easier
debugging. Hm. Maybe move the comment on line 1319 up here? And
perhaps only hash if the name is too long? I doubt it'll happen too
often, and there won't be any conflict.
- line 1376: this doesn't look like it'll be a relative link, but it
should be.
- line 1377: no need to symlink "attrs"?
- line 1426,1431: I don't see how these are defined differently. Won't
line 1437 always evaluate False? Should src_sigs be defined before
line 1421?
- line 1479: wouldn't 'if PKG_STATE_V0 not in mdata["states"]" represent
what you're actually trying to do better, or am I misunderstanding how
the list of states works?
- line 1487: I don't see how this could ever be True. It would have to
be either None or an empty dict, and in either case, the tests on lines
1473, 1479, or 1484 would have blown up.
- __refresh_v0, __refresh_v1: document what the return value is in the
docstring?
transport.py:
- line 197: "alternative" -> "alternate"
- line 201: why not just put the return into a try/except KeyError
clause?
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
