On 05/12/11 03:52 PM, Danek Duvall wrote:
Shawn Walker wrote:
On 05/12/11 02:13 PM, Danek Duvall wrote:
Shawn Walker wrote:
http://cr.opensolaris.org/~swalker/pkg-composite-2/
catalog.py:
- line 3411: this disallows ver == 0, if I'm reading it correctly.
Since it is always supposed to be a string (per docstring), no.
Okay; missed that.
But even then, 'ver' will never be just 0 for our use (it'll always be
something like 1.0,5.11, etc.):
I've used @0 as a test quite frequently.
Hmm, I thought we had hard-coded PkgFmri to default to 5.11. Nevermind.
But anyway, it's always a string, so no concerns here.
publisher.py:
- line 1238,1239: First "list", then "set", plus the name of the method?
It doesn't mean "set" literally (as in the data type). This is the
logical sort of set; perhaps 'combo' instead of 'set'?
I think a bit more consistency in the docstring is all that's needed here.
Okay, I've replaced 'set' with 'group' in the docstring. Does that work?
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
