Brock Pytlik wrote:

> http://cr.opensolaris.org/~bpytlik/ips-17808-v1/

Why are you adding "/64" to the runpath entries, rather than "/amd64" or
"/sparcv9" as appropriate?  The "64" symlink might not exist, and it
requires you to go through symlink resolution if it does, which seems like
extra work.  Besides, is that what the runtime linker actually uses, or
does it go directly for the 64-bit architecture name?

I also wonder if the addition should happen outside the "if p not in rp"
check -- otherwise, you could end up with a situation where the internal
runpath had /usr/lib/64, but because that wasn't in default_run_paths, it
got added to rp with the "/64" tail, duplicating what was already there.

Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to