On 06/01/11 11:21, Danek Duvall wrote:
Brock Pytlik wrote:
http://cr.opensolaris.org/~bpytlik/ips-17808-v1/
Why are you adding "/64" to the runpath entries, rather than "/amd64" or
"/sparcv9" as appropriate? The "64" symlink might not exist, and it
requires you to go through symlink resolution if it does, which seems like
extra work. Besides, is that what the runtime linker actually uses, or
does it go directly for the 64-bit architecture name?
The links from /usr/lib/64 and /lib/64 are both delivered in
system/library. To me, it looked to me like the chances of having a
functioning system without that package were pretty slim. Also, it
seemed silly and more complicated to have pkgdep adding directories
conditioning not only on the bitness, but also on the platform when
there was already a single link which gets pointed to the correct
location on the correct platforms. Finally, at least according to crle
and Rod, the linker actually goes through /lib/64 and /usr/lib/64.
# crle -64
Default Library Path (ELF): /lib/64:/usr/lib/64 (system default)
I also wonder if the addition should happen outside the "if p not in rp"
check -- otherwise, you could end up with a situation where the internal
runpath had /usr/lib/64, but because that wasn't in default_run_paths, it
got added to rp with the "/64" tail, duplicating what was already there.
Good point, I'll move lines 225, 226 to between 223 and 224.
Thanks for taking a look.
Brock
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
