On Fri, Jul 08, 2011 at 11:46:34AM +1200, Tim Foster wrote: > Hi there, > > I've a tiny webrev here (4 lines changed, the rest of the webrev is code > deletion) that I'd appreciate a review of please, fixing: > > 18369 pkgdep tests that rely on python2.4 need to be removed > 18496 history needs to cope with get_username failing > > https://cr.opensolaris.org/action/browse/pkg/timf/history-getpwnam/history-getpwnam-webrev/ > > I have no automated tests for the pkg history bug, but verified the > fixed behaviour manually (creating a user, su'ing to that user, then > removing its entry from /etc/passwd, then running a packaging command, > which was previously causing us to hit the bug) > > I ran the pkgdep tests on a system with no python-24 package installed, > and they passed. >
so the pkg history fix looks fine to me. i do have some comments on the test change though... - your deleting two functions, but you're not deleting some variables only used by those functions (pyver_test_manf_1). - you added a comment saying the tests will need to be brought back if we ship another python interpreter. is this really true? or do they only need to be brought back if we ship another python interpreter and parts of the packaging system use it? - given that we're deleting a bunch of code that we might just need to resurrect soon, would it be possible to update these tests to run with the 2.6 interpreter and just leave them in place so when the next version comes along we just update them again? (instead of undeleting them.) ed _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
