On 07/07/11 16:46, Tim Foster wrote:
Hi there,
I've a tiny webrev here (4 lines changed, the rest of the webrev is code
deletion) that I'd appreciate a review of please, fixing:
18369 pkgdep tests that rely on python2.4 need to be removed
18496 history needs to cope with get_username failing
https://cr.opensolaris.org/action/browse/pkg/timf/history-getpwnam/history-getpwnam-webrev/
I have no automated tests for the pkg history bug, but verified the
fixed behaviour manually (creating a user, su'ing to that user, then
removing its entry from /etc/passwd, then running a packaging command,
which was previously causing us to hit the bug)
I ran the pkgdep tests on a system with no python-24 package installed,
and they passed.
cheers,
tim
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
LGTM. Only comment is that adding in the current gate version/hash
before putting back as part of the comment of 18101 might be nice. That
way, we don't have to hg grep trying to find the test that used to
exist. That said, if people prefer the hg grep approach, that's fine w/
me too.
Brock
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
