On 07/ 5/11 04:57 PM, Edward Pilatowicz wrote:
directory.py:
- nit: s/matches specified/matches a specified/ (or perhaps something
else, but the grammar is currently weird.)
general:
- i don't see any clear documentation / discussion / test case about how
salvage_from deals with subdirectories. from looking at the code it
seems that if i said salvage_from /foo into /bar, then i would salvage
anything orphaned in /foo including stuff in subdirectories? so for
example, if the directories /foo and /foo/baz were still being
delivered but the directory /foo/baz/bong was going away, then we'd
salvage /foo/baz/bong in /bar/baz/bong, right?
Yes... it takes all the contents underneath (directories and files)
and put them in the new directory.
- shouldn't there be action conflict checking to make sure that two
directory actions with different target paths don't each have
overlapping salvage_from path attributes?
Well, we could do this - but since nothing bad happens if this occurs
(one directory gets the salvaged stuff, the other doesn't) this is
likely ok. Note that this salvage_from attribute is only honored on
directory creation, so the likely use case is in the next version of
the same package, renaming an existing directory that has unpackaged
contents.
- shouldn't a salvage_from attribute only be respected if the
salvage_from path was previously delivered by an installed package
action? (right now when the directory install actions does it's
evaluation it check to see if the source is present, but not if it was
previously delivered by a directory action.)
Why is this restriction necessary? With the way this is now, different
subdirectories could be salavaged into different places.
- Bart
--
Bart Smaalders Solaris Kernel Performance
[email protected] http://blogs.sun.com/barts
"You will contribute more with Mercurial than with Thunderbird."
"Civilization advances by extending the number of important
operations which we can perform without thinking about them."
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
