On 07/ 9/11 09:28 AM, Shawn Walker wrote:
On 06/28/11 11:53, Bart Smaalders wrote:
src/modules/client/image.py: line 3618: I thought we had determined that it returning sdir twice was a bug?
I'll fix this; it's ugly.
src/tests/cli/t_pkg_install.py: lines 1508-1509: How does this work given that the code in pkg.actions.directory is looking for 'salvage-from', *not* 'salvage_from' (not the underscore vs. hyphen; it should be a hyphen, btw. there's a war on underscores right now :))
typo; I changed to '-' after running test suite and before webrev.
pkg(5) needs updating too.
ok.
I also share Ed's concerns about different directories claiming the same salvage-from.
As I said to Ed, this is doesn't hurt anything. It might be something to check in pkglint, but it doesn't affect correctness of the image. - Bart -- Bart Smaalders Solaris Kernel Performance [email protected] http://blogs.sun.com/barts "You will contribute more with Mercurial than with Thunderbird." "Civilization advances by extending the number of important operations which we can perform without thinking about them." _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
