On 08/12/11 08:49, Danek Duvall wrote:
Turns out we have to strip the CDDL from the binary product:

     https://cr.opensolaris.org/action/browse/pkg/dduvall/decddl/

src/setup.py:
  line 571: why "files == []" instead of "not files" ?

line 702: is intentional that this sets it to current time/date for each os.utime op instead of a single date/time determined at the start of execution? I know we have code that resets the .py files, but what about other files? Or am I confused?

lines 901, 904: Might add a comment above these stating they're required to be implemented by distutils.cmd.

lines 879: this will fail if you have a new python file you've created (and may or may not have hg added) but haven't committed yet when running make install

My Makefile fu is weak, so I can't speak to those changes with confidence.

I tested your changes locally, and other than above, everything seems to check out with an older gate revision. (make check, make packages, etc.)

-Shawn


_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to