Hi Danek, nice subject :-)
On Fri, 2011-08-26 at 15:58 -0700, Danek Duvall wrote: > https://cr.opensolaris.org/action/browse/pkg/dduvall/decddl/ Looks good in general - it might be worth doing a protocmp of proto areas built before and after this change if you haven't done so already? In places where you call run_cmd, line 651, 659, 672 could we use a full path to the executable, rather than just its name, or define the full paths elsewhere in setup.py? I had a go with the _copy_file_contents() function on a file with the CDDL included, and found that it left me with: --- #!/usr/bin/python2.6 # Copyright (c) 2008, 2011, Oracle and/or its affiliates. All rights reserved. # # do stuff --- is there any chance we could keep a trailing comment line after the end-CDDL marker, so that we get: --- #!/usr/bin/python2.6 # # Copyright (c) 2008, 2011, Oracle and/or its affiliates. All rights reserved. # # do stuff --- instead? So, have a blank line inserted immediately before the line containing 'CDDL HEADER START', and collapse multiple blank lines after 'CDDL HEADER END' (rather than sucking in empty comment lines) Of course, it's easier to ask for this than it is to provide a fix :-) If you don't get to this tomorrow, I'll give it a go then, but I guess it's not really a big deal. cheers, tim _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
