On 08/28/11 22:35, Tim Foster wrote:
Hi Brock,

On Fri, 2011-08-26 at 09:53 -0700, Brock Pytlik wrote:
https://cr.opensolaris.org/action/browse/pkg/bpytlik/18856-v1
Do you know if there's a bug open to get an API to pkgfmt?  ('pkgsend
generate' would also benefit from it)

I couldn't find one, so I filed 18874.

src/modules/actions/depend.py, line 328 - typo "designed"


I dug around the pretty_print code a little, trying a a bunch of
examples on the command line, and they all looked good.  I did see that
we're allowed to do:

d = d.DependencyAction(fmri="foo", type="require", a=123)
which validates, but runs us into:

d.validate()
d
Traceback (most recent call last):
   File "<input>", line 1, in<module>
   File "/usr/lib/python2.6/vendor-packages/pkg/actions/generic.py", line
390, in __repr__
     self)
   File "/usr/lib/python2.6/vendor-packages/pkg/actions/generic.py", line
371, in __str__
     elif " " in v or "'" in v or "\"" in v or v == "":
TypeError: argument of type 'int' is not iterable

but that's not part of your change, and I don't think that can happen in
the real world though, so probably nothing to worry about.

Otherwise, looks good.

Thanks for taking a look,
Brock

        cheers,
                        tim


_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to