On 08/26/11 14:18, Shawn Walker wrote:
On 08/26/11 09:53, Brock Pytlik wrote:
Webrev:
https://cr.opensolaris.org/action/browse/pkg/bpytlik/18856-v1
Bug:
18856 resolve errors need readability help for file dependencies
The formatting code was lifted from pkgfmt. I initially looked at making
a common method, but that was difficult because of the pkgfmt's use of
global variables for communication. When we create a common framework
for printing actions nicely, this code should switch to using those
methods.
Looks fine to me, the only comment I'd have is that the base_indent
parameter seems pointless. Especially if we go back later and try to
make it use common formatting logic.
I'd just hard-define the 4-space indent and move on.
Ok. Thanks for looking at it.
Brock
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
