On 09/01/11 22:19, Tim Foster wrote:
hi all,

I've a few more pkglint changes yet to make, but have had these ones
hanging around for a while, hoping to eventually bundle all the
pkglint-related changes together.

However, given a few distractions of late, I figure getting these back
early would be better:

https://cr.opensolaris.org/action/browse/pkg/timf/pkglint_whinge_less/pkglint_whinge_less-webrev/

This will help out userland as it allows them to make pkglint a bit less
chatty when discovering pkg.linted flags in manifests, as well as adding
a custom pkglintrc file for our build, which David was asking for.

comments welcome,

        cheers
                        tim

_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
I have general concerns about fixing bug 18673, at least as generally as described. I don't think that all packages linted should need to contain the same set of declared variants, but I do think that if a package has an action which uses a particular variant (debug or not) it should declare that variant in a set action. What's missing for me (in bug 18673 and the associated mails) is an explanation of why we want to skip debug variants. We have one case where it actually caught a bug that would've gone unnoticed otherwise (bug 18884).

Other than that, the changes look good!
Brock

_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to