Tim Foster wrote:

> https://cr.opensolaris.org/action/browse/pkg/timf/pkglint_whinge_less/pkglint_whinge_less-webrev/

pkglint.py:

  - line 278: I think I'd recommended to Shawn in a previous review not to
    name build_release, and just treat it as an optional positional
    parameter, so I'll do the same here.  But why not just put "5.11" in
    the first attempt at object creation?  The parameter is only used if
    the version isn't in the fmri string.

  - line 283: str() call isn't necessary, given that it's for a %s.

Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to