Mike Gerdts wrote:

> I noticed that pkg:/system/data/timezone has a bunch of file actions
> with an attribute of preserve=false.  Because of this snippit from
> pkg(5):
> 
>                  If the value of preserve is true (or a value not
>                  listed  above,  such  as  strawberry),  then the
>                  existing file is left alone, and the new file is
>                  not installed.
> 
> It would seem as though
> 
>       true == strawberry == false
> 
> Which makes me think that this is bad.  The "defaults" transform in
> userland adds it:
> 
>      51 # zoneinfo files
>      52 #
>      53 <transform file path=usr/share/lib/zoneinfo/.+ -> default mode 0644>
>      54 <transform file path=usr/share/lib/zoneinfo/.+ -> default preserve 
> false>
> 
> Line 54 should be whacked, right?  If not, what am I missing?

Yeah.  I don't know why that line would be there at all, anyway -- it's as
if the author thought that they were trying to remove a preserve attribute,
but I don't know why it would be there in the first place.  I'm also
curious why the files should be writable.  One of the RTI comments says
"it is just historical", which isn't a good reason.  No comments on the
preserve attribute -- probably code reviewers that didn't quite understand
what that was all about, and none of the reviewers are folks with much IPS
experience (to my knowledge).

Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to