On Mon 14 Nov 2011 at 10:45AM, Norm Jacobs wrote:
> On 11/13/11 10:47 PM, Mike Gerdts wrote:
> >I noticed that pkg:/system/data/timezone has a bunch of file actions
> >with an attribute of preserve=false.  Because of this snippit from
> >pkg(5):
> >
> >                  If the value of preserve is true (or a value not
> >                  listed  above,  such  as  strawberry),  then the
> >                  existing file is left alone, and the new file is
> >                  not installed.
> >
> >It would seem as though
> >
> >     true == strawberry == false
> >
> >Which makes me think that this is bad.  The "defaults" transform in
> >userland adds it:
> >
> >      51 # zoneinfo files
> >      52 #
> >      53<transform file path=usr/share/lib/zoneinfo/.+ ->  default mode 0644>
> >      54<transform file path=usr/share/lib/zoneinfo/.+ ->  default preserve 
> > false>
> >
> >Line 54 should be whacked, right?  If not, what am I missing?
> >
> These lines look wrong to me.  The zoneinfo files shouldn't be
> writable and there is no need for a preserve attribute.  It looks
> like the mode transform was replicated from ON when the zoneinfo
> files moved to userland and the preserve attribute would have been
> added to make pkglint happy because the userland gate checks require
> you to declare your intention when you make a file writable.  There
> is no reason for these files to be writable, these transforms should
> probably be removed.  Please file a bug under
> solaris/utility/timezone.

I've filed:

7111691 timezone files packaged with inappropriate preserve=false attribute

-- 
Mike Gerdts
Solaris Core OS / Zones
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to